-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reconsider the Type float/Float in the API #712
Comments
It would be nice to use |
I agree, thanks for raising the issue. I will aim to fix this for the M2 release that is coming up shortly. |
@markpollack should this be moved to next milestone or release candidate? |
I'm available to submit a PR on this. I had already done some preliminary analysis when working on the observability features. I should have the PR ready by the end of this week. |
* The type of the portable chat options (frequencyPenalty, presencePenalty, temperature, topP) has been changed from Float to Double. * APIs, test, and documentation have been updated accordingly. Fixes spring-projectsgh-712 Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
The PR is ready for review: #1325 |
A floating-point number with limited precision is commonly used in AI. However, using
float
orFloat
as a data type in the API might be impractical, and it could be worth reevaluating this decision.For instance, your own example in the reference documentation (https://docs.spring.io/spring-ai/reference/api/clients/ollama-chat.html) results in a compiler error, guess why :)
The text was updated successfully, but these errors were encountered: