Entra ID support for auto config #2572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheovanKraay Thanks for the PR! Could you complete the DCO check (by signing off your commit: git commit --amend --signoff) and fix the PR build failure (there is a format issue)? |
TheovanKraay
force-pushed
the
cosmos-db-entra-id-support
branch
2 times, most recently
from
9e35834 to
86dccae
Compare
|
Thank @ilayaperumalg I've done as you requested. Let me know if there are other issues blocking merge/release? |
|
Hi @ilayaperumalg and all - any eta on when this could be merged and released? I have some other fixes/enhancements I want to make behind this one, but doing them in small increments. Thanks! |
TheovanKraay
force-pushed
the
cosmos-db-entra-id-support
branch
2 times, most recently
from
918a8c9 to
e988ca0
Compare
|
@ilayaperumalg since the PR is not merged yet, I added another small fix to expose metadata fields in response. I have some more changes planned but will hold off now until this is merged. Hoping it can be pushed soon. Thanks again. |
Signed-off-by: Theo van Kraay <theo.van@microsoft.com>
…van@microsoft.com> Signed-off-by: Theo van Kraay <theo.van@microsoft.com>
Signed-off-by: Theo van Kraay <theo.van@microsoft.com>
Signed-off-by: Theo van Kraay <theo.van@microsoft.com>
TheovanKraay
force-pushed
the
cosmos-db-entra-id-support
branch
from
712e67e to
fd959fd
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Entra ID in the auto config for Azure Cosmos DB vector store support.
This PR also adds a few fixes/enhancements and corresponding tests: