Skip to content

Use early static registration of EventPublishingContextWrapper in tests #42005

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
philwebb opened this issue Aug 22, 2024 · 1 comment
Closed

Use early static registration of EventPublishingContextWrapper in tests #42005

philwebb opened this issue Aug 22, 2024 · 1 comment
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
3.4.0-M3

Comments

@philwebb
Copy link
Member

See #41439 (comment).

We should try to make things work seamlessly with JUnit and possibly consider making some form of EventPublisherBeansContextWrapper.addWrapperIfNecessary public so that folks can all it directly.
@philwebb philwebb added the type: enhancement A general enhancement label Aug 22, 2024
@philwebb philwebb added this to the 3.3.4 milestone Aug 22, 2024
@philwebb philwebb mentioned this issue Aug 22, 2024
Closed
@mhalbritter mhalbritter modified the milestones: 3.3.4, 3.4.x Aug 23, 2024
@wilkinsona
Copy link
Member

Somewhat related to this, shouldPublishEventsWhenContextStorageIsInitializedEarly() in OpenTelemetryAutoConfigurationTests is 100% flaky at the moment.

wilkinsona added a commit that referenced this issue Aug 23, 2024
@wilkinsona
Try to stop test from being flaky
d71fe11 
See gh-42005
See gh-41439
@philwebb philwebb self-assigned this Sep 10, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.4.0-M3 Sep 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4.0-M3
Development

No branches or pull requests
3 participants
@philwebb @wilkinsona @mhalbritter