-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Support Reactor Netty in ClientHttpRequestFactories #42587
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
wilkinsona
added a commit
that referenced
this issue
Oct 18, 2024
I wonder, if like the jdk http client, this should be opt-in by default in a minor. spring-cloud/spring-cloud-gateway#3562 |
spencergibb
added a commit
to spencergibb/spring-cloud-gateway
that referenced
this issue
Oct 22, 2024
Since spring-projects/spring-boot#42587, the default http client changed when webflux is on the classpath. Fixes spring-cloudgh-3562
Reopening to consider if we should make this opt-in (similar to jdk http client) |
One backward incompatibility was not sending the body on a |
spencergibb
added a commit
to spring-cloud/spring-cloud-gateway
that referenced
this issue
Oct 22, 2024
Since spring-projects/spring-boot#42587, the default http client changed when webflux is on the classpath. Fixes gh-3562
We're going to keep it as a default, but #36266 will make it easier to change. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
RestClient support in #36213 was followed by JDK HttpClient and Jetty client support in
ClientHttpRequestFactories
, #36118 and #36116.ReactorClientHttpRequestFactory
was added soon after in Spring Framework, but there is no corresponding support inClientHttpRequestFactories
as of yet.Note that
ReactorClientHttpRequestFactory
was calledReactorNettyClientRequestFactory
in 6.1, but was recently renamed in spring-projects/spring-framework@042346a. In case you wonder why it's marked with@since 6.2
.The text was updated successfully, but these errors were encountered: