Various spring.datasource properties are mistakenly marked as ignored

[kzander91]

Commit 8536520 in #43988 added a variety of properties to a list of ignored properties due them being "unbindable", however several of them are bindable.

I have been using the following properties just fine for years, however when building against 3.5.0 snapshots, my IDE is now giving me warnings about those properties being unknown. Note that binding them at runtime still works though:

• spring.datasource.hikari.data-source-properties, example: spring.datasource.hikari.data-source-properties.oracle.jdbc.ReadTimeout=60000.
• spring.datasource.oracleucp.connection-properties, example: spring.datasource.oracleucp.connection-properties.oracle.jdbc.ReadTimeout=60000.

I'm not using spring.datasource.hikari.health-check-properties, but that seems to be affected as well.

I propose to review the list of ignored properties and reinstate those that are indeed bindable.

[mhalbritter]

Hey,

thanks for giving the milestones / release candidates / snapshots a try!

I mistakenly thought that Properties aren't bindable. Those properties are indeed bindable:

• spring.datasource.hikari.data-source-properties
• spring.datasource.hikari.health-check-properties
• spring.datasource.oracleucp.connection-factory-properties
• spring.datasource.oracleucp.connection-properties
• spring.datasource.oracleucp.pdb-roles
• spring.datasource.tomcat.db-properties

[kzander91]

Thanks @mhalbritter, warnings are gone with the latest snapshots 👍

[mhalbritter]

Thanks for confirming!