Skip to content

Polish some external documentation links #18384

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed

Conversation

dreis2211
Copy link
Contributor

Hi,

the doc polishing goes on. Sorry for the amount of small PRs. This particular one polishes some external documentation links - namely:

  • Point to Jetty documentation of currently supported Jetty version
  • Point to Hibernate 5.4 instead of 5.3
  • Point to current Gradle docs instead of deprecated 4.2.1 (or any other 4.x) version

Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 27, 2019
@philwebb philwebb added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 27, 2019
@philwebb philwebb added this to the 2.2.x milestone Sep 27, 2019
philwebb pushed a commit that referenced this pull request Sep 28, 2019
@philwebb philwebb closed this in a465ebe Sep 28, 2019
@philwebb
Copy link
Member

philwebb commented Sep 28, 2019

Sorry for the amount of small PRs

No need to apologize, we prefer merging lots of smaller PRs to splitting up large ones :)

Thanks once again!

@philwebb philwebb modified the milestones: 2.2.x, 2.2.0.RC1 Sep 28, 2019
@dreis2211
Copy link
Contributor Author

I wonder about the force push and the references to the other commits. Could you elaborate?

@philwebb
Copy link
Member

I rather foolishly managed to commit a heap dump file that was generated when my JVM crashed. Rather than revert it and leave it in the history, I decided to risk an immediate force push.

philwebb pushed a commit that referenced this pull request Sep 29, 2019
philwebb added a commit that referenced this pull request Sep 29, 2019
* pr/18384:
  Polish some external documentation links

Closes gh-18384
@dreis2211
Copy link
Contributor Author

I noticed this when syncing my fork as it got ouf sync because of this. I could fix it for mine by resetting master hard to the upstream master. Might happen to some more people.

@philwebb
Copy link
Member

I managed to really mess it up badly by accidentally deleting a merge commit that I shouldn't have. I tried again to fix it yesterday so you'll probably need to do another git reset --hard

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants