-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Add support for Micrometer tracing #30251
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
b87a0ad
to
3be618c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Mortiz. I've left a few comments for your consideration.
Could you also double-check that any new packages that are introduced have package-info.java
files.
...ramework/boot/actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsProperties.java
Outdated
Show resolved
Hide resolved
.../actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsPropertiesConfigAdapter.java
Outdated
Show resolved
Hide resolved
...g/springframework/boot/actuate/autoconfigure/tracing/MicrometerTracingAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinProperties.java
Outdated
Show resolved
Hide resolved
...springframework/boot/actuate/autoconfigure/tracing/zipkin/ZipkinRestTemplateSenderTests.java
Show resolved
Hide resolved
...a/org/springframework/boot/actuate/autoconfigure/tracing/wavefront/NoopSpanMetricsTests.java
Outdated
Show resolved
Hide resolved
...ingframework/boot/actuate/autoconfigure/tracing/wavefront/MeterRegistrySpanMetricsTests.java
Show resolved
Hide resolved
ed0d60a
to
36b04d6
Compare
These are the dependency combinations i have tested with and which produce spans in backends:
For Wavefront, at least the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you. Particular thanks for testing the auto-configurations so thoroughly.
I've left a few comments, almost entirely minor and trivial polishing. The one thing that I think requires some further thought is around the use of spring.application.name
. Please take a look and see what you think. My feeling is that we should create a separate issue and review things more broadly as it affects more than this new tracing support.
...gframework/boot/actuate/autoconfigure/metrics/export/properties/PropertiesConfigAdapter.java
Outdated
Show resolved
Hide resolved
.../actuate/autoconfigure/metrics/export/wavefront/WavefrontMetricsExportAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/boot/actuate/autoconfigure/tracing/BraveAutoConfiguration.java
Show resolved
Hide resolved
...java/org/springframework/boot/actuate/autoconfigure/tracing/OpenTelemetryConfigurations.java
Show resolved
Hide resolved
...igure/src/main/java/org/springframework/boot/actuate/autoconfigure/tracing/package-info.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/actuate/autoconfigure/wavefront/WavefrontProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/actuate/autoconfigure/wavefront/WavefrontProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/actuate/autoconfigure/wavefront/WavefrontProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/boot/actuate/autoconfigure/wavefront/WavefrontProperties.java
Outdated
Show resolved
Hide resolved
...ure/src/main/java/org/springframework/boot/actuate/autoconfigure/wavefront/package-info.java
Outdated
Show resolved
Hide resolved
36b04d6
to
fd49505
Compare
Blocked on micrometer-metrics/tracing#16 |
fd49505
to
76ec8d7
Compare
- Configure Zipkin - Configure Wavefront - Configure Brave - Configure OpenTelemetry - Configure Micrometer Tracing bridges for OpenTelemetry and Brave - Create the ObservationHandler for tracing with Micrometer Closes spring-projectsgh-30156
76ec8d7
to
07543a4
Compare
Rebased and put into |
Implements auto-configurations for Micrometer Tracing
See gh-30156
So far this auto-configuration supports: