Update initialization of WebSocket handler in GraphQlWebMvcAutoConfiguration #30641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a result of changes for spring-projects/spring-graphql#342, GraphQlWebSocketHandler now exposes a method to create the WebSocketHttpRequestHandler, pre-configured with a context propagating HandshakeInterceptor. This commit updates the autoconfig to use it.
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: enhancement
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphQlWebSocketHandlernow exposes a method to create theWebSocketHttpRequestHandlerinstance to use, that's pre-configured with aHandshakeInterceptorfor context propagation. This is a result of changes for spring-projects/spring-graphql#342.This pull request updates how the
WebSocketHttpRequestHandleris created in the auto configuration, making use of this new method, in order to complete the fix for spring-projects/spring-graphql#342.