-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
jOOQ DefaultConfiguration does not use TransactionProvider #33979
Conversation
@ath0s Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
This comment was marked as outdated.
This comment was marked as outdated.
@ath0s This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
@ath0s Unfortunately, this doesn't qualify as an obvious fix as it changes functionality. Please sign the CLA. |
@ath0s Thank you for signing the Contributor License Agreement! |
This was intentional (see https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.5-Release-Notes#customizing-jooqs-defaultconfiguration and #24732) but I think we went too far. Given that Boot itself defines the |
Thanks very much for the PR, @ath0s. |
Problem
A jOOQ
TransactionProvider
bean is created, but is not configured to be used by theDefaultConfiguration
. This applies to Spring Boot 3.0.0, 3.0.1, 3.0.2.A recent commit (51df781) removed the
DefaultConfigurationCustomizer
that configuredDefaultConfiguration
to use theTransactionProvider
if such a bean was available.Solution
This PR sets the
TransactionProvider
(if available) when creating theDefaultConfiguration
.