-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Remove stale link to jar-to-war getting started guide #42691
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Spring Boot 3.3.4 Reference Doc. Changed the Not Found link provided in the Reference Doc to a link covering the Build Plugin. Reference Doc : https://docs.spring.io/spring-boot/how-to/deployment/traditional-deployment.html#howto.traditional-deployment.convert-existing-application Not Found Link : Getting Started Guide on Converting a jar to a war. ( https://spring.io/guides/gs/convert-jar-to-war/ )
@IMWoo94 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@IMWoo94 Thank you for signing the Contributor License Agreement! |
Thanks for the PR. The guide has been dropped so this looks like an oversight, see #42110 |
Thank you for finding the issue The current PR provides a new link, but can I delete it and rewrite it with the code that's been removed? |
Thanks for the PR. I don't think we should reproduce the code from the old guide, but we should update the link when we merge this. It should be |
Update can be carried out in two ways. 1. "See the Getting Started Guide on Converting a jar to a war." comment delete 2. Modify links using xref:build-tool-plugin:index.adoc[] #42110 and the comments I think option 1 is correct so current PR option 1 apply. |
Spring Boot 3.3.4 Reference Doc. Not Found link(See the Getting Started Guide on Converting a jar to a war.) remove in the Reference Doc
Thanks @IMWoo94 |
Version : Spring Boot 3.3.4 Reference Doc.
Changed the Not Found link provided in the Reference Doc to a link covering the Build Plugin.
The reference Doc already provides a direct content to Jar and War. I think it would create better synergy if you provided a link to the Build Tool rather than providing a removed guide.
Reference Doc : https://docs.spring.io/spring-boot/how-to/deployment/traditional-deployment.html#howto.traditional-deployment.convert-existing-application
Not Found Link : Getting Started Guide on Converting a jar to a war.
Suggest Link : Build Tool Plugins