-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove deprecated ZipkinSender #43052
Remove deprecated ZipkinSender #43052
Conversation
…Configuration`, `RestTemplateSenderConfiguration` class.
71369e4
to
5e74bdf
Compare
Thanks for the PR, @wickdynex. Unfortunately, this is changing too many different things for a single PR. Please just focus on the changes for #42589 as already described by @mhalbritter:
|
Alright, maybe I should split this PR into 3 pieces for 3 issues🤔? I feel sorry to deal many issues in a single PR, it makes |
You can either:
One thing at a time please. Let's get a PR for #42589 into a state where it's ready to be merged before considering the other two issues. |
I can see you created a new PR. closing this one |
Yeah, thanks for your help🥳. |
Description
This PR have removed three
SenderConfiguration
also itsSender
:UrlConnectionSenderConfiguration
,RestTemplateSenderConfiguration
andWebClientSenderConfiguration
in fileZipkinConfigurations
. Remove the related test cases about theseSenderConfiguration
class in fileZipkinConfigurationsSenderConfigurationTests
.Related Issue
Fixed #42589, #43047, #43048
Type of Change
Checklist
Screenshots
Additional Notes
I does remove the other
Senders
and itsSenderConfiguration
class, and also remove the test class related to these deprecated🥰. But do I need refactorZipkinConfiguration
structure, and write some test case to integrate test this modified class.🤨 Also update the documents about this related Sender🤔. Please give me some advice if this PR can't be merged🥹, and I will try my best to fix it up. Looking forward to your reply❤️~