Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace TestObservationRegistryAssert.assertThat() with Assertions.assertThat() #43235

Closed
wants to merge 1 commit into from
Closed

Replace TestObservationRegistryAssert.assertThat() with Assertions.assertThat() #43235

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Nov 21, 2024

This PR replaces TestObservationRegistryAssert.assertThat() with Assertions.assertThat().

See micrometer-metrics/micrometer#5551

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 21, 2024
@philwebb philwebb added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 21, 2024
@philwebb philwebb modified the milestones: 3.2.x, 3.4.0 Nov 21, 2024
philwebb pushed a commit that referenced this pull request Nov 21, 2024
@izeye @philwebb
Replace TestObservationRegistryAssert.assertThat()
4b5b76d 
See gh-43235
philwebb added a commit that referenced this pull request Nov 21, 2024
@philwebb
Polish 'Replace TestObservationRegistryAssert.assertThat()''
c9a8454 
See gh-43235
@philwebb philwebb closed this in 933b7d3 Nov 21, 2024
@philwebb
Copy link
Member

Thanks @izeye

@izeye izeye deleted the assert branch November 21, 2024 05:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@izeye @philwebb @spring-projects-issues