Add support for multiple StructuredLoggingJsonMembersCustomizers #43368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
changed the title
logging.structured.json.customizer accept multiple Customizers also
philwebb
added
type: enhancement
snicoll
added
the
for: team-attention
|
Should |
…also See spring-projects#43312 (comment) Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
philwebb
changed the title
philwebb
pushed a commit
that referenced
this pull request
Jan 24, 2025
Update `StructuredLoggingJsonProperties` and related class so that multiple `StructuredLoggingJsonMembersCustomizer` classes can be used. Signed-off-by: Yanming Zhou <zhouyanming@gmail.com> See gh-43368
philwebb
added a commit
that referenced
this pull request
Jan 24, 2025
|
Thanks @quaff, I've kept both the |
philwebb
removed
the
for: team-attention
wilkinsona
added
the
for: team-meeting
arefbehboudi
pushed a commit
to arefbehboudi/spring-boot
that referenced
this pull request
Jan 29, 2025
Update `StructuredLoggingJsonProperties` and related class so that multiple `StructuredLoggingJsonMembersCustomizer` classes can be used. Signed-off-by: Yanming Zhou <zhouyanming@gmail.com> See spring-projectsgh-43368 Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
arefbehboudi
pushed a commit
to arefbehboudi/spring-boot
that referenced
this pull request
Jan 29, 2025
…ers' See spring-projectsgh-43368 Signed-off-by: arefbehboudi <behboodiaref@gmail.com>
|
Reopening because we discussed this today and we're going to keep just the singular |
bclozel
removed
the
for: team-meeting
philwebb
added a commit
that referenced
this pull request
Jan 29, 2025
Update `StructuredLoggingJsonProperties` no that only a single `customizer` property is supported. See gh-43368
philwebb
added a commit
that referenced
this pull request
Jan 29, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #43312 (comment)