Provide a configuration property for Spring Batch's validateTransactionState #44803
Conversation
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
| /** | ||
| * Whether to validate the transaction state. | ||
| */ | ||
| private Boolean validateTransactionState; |
There was a problem hiding this comment.
This could be a boolean with a default value of true.
There was a problem hiding this comment.
I think it should align with tablePrefix since it's not default to BATCH_, Spring Boot doesn't need to change if Spring Batch change its defaults, but many other AutoConfigurations doesn't work in such way.
There was a problem hiding this comment.
Our approach has changed over time. These days, we prefer to provide a default if we can as it's better for users when looking at a property and its documentation, particularly in an IDE that supports that through the metadata. It's very unlikely that Batch will change its default. If it does, there's now a test in place that will fail.
There was a problem hiding this comment.
we prefer to provide a default if we can as it's better for users when looking at a property and its documentation, particularly in an IDE that supports that through the metadata.
Then tablePrefix and isolationLevelForCreate should have default value.
wilkinsona
added
for: merge-with-amendments
See gh-44803 Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
|
Thanks, @quaff. |
No description provided.