Add missing attributes to ServletRegistration annotation #45006
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytrodanilenkov
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
dmytrodanilenkov
force-pushed
the
fix-issue-45001
branch
from
29100b0 to
a705fe9
Compare
added 2 commits
April 4, 2025 19:16
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: dmytrodanilenkov <d.danilenkov.ext@sportradar.com>
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com> Signed-off-by: dmytrodanilenkov <d.danilenkov.ext@sportradar.com>
dmytrodanilenkov
force-pushed
the
fix-issue-45001
branch
from
9486831 to
ab74295
Compare
…se properties, but @ServletRegistration hasn't: initParameters, servletRegistrationBeans, multipartConfig Signed-off-by: Dmytro Danilenkov <milgoff@gmail.com>
|
Duplicates #45005. |
wilkinsona
added
status: duplicate
|
Thanks, @dmytrodanilenkov, but someone else opened a PR for the same change a little before you. |
|
@wilkinsona not sure I got it. I opened for #45001, not for #45000 |
|
Oops, sorry about that. I was confused by the references to #45000 in the commit messages. |
mhalbritter
changed the title
mhalbritter
reviewed
Apr 7, 2025
| @Target({}) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| @interface MultipartConfigValues { |
There was a problem hiding this comment.
Could we directly use jakarta.servlet.annotation.MultipartConfig here?
mhalbritter
added
status: waiting-for-feedback
|
Dupe of #45007. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45001