Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add exception translation for DriverTimeoutException #1399

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Jun 23, 2023

Cassandra spring-data module does not recogize the DriverTimeoutException, which essentially means that driver has timed out during interaction with cluster in general.

Maybe we should consider to not throw QueryTimeoutException, but create a separate one, specifically for this case.

@mp911de @schauder please, take a look.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 23, 2023
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 23, 2023
@mp911de
Copy link
Member

mp911de commented Jun 23, 2023

It makes sense to add the mapping. Care to retain the original cause and add unit tests?

@mp911de mp911de self-assigned this Jun 23, 2023
@mipo256
Copy link
Contributor Author

mipo256 commented Jun 23, 2023

Of course, I will. So I'll just:

  1. Create new Exception mapping for this DriverTimeoutException of datastax driver
  2. Add a unit test for this case and preserve the cause

@mipo256 mipo256 force-pushed the feature/exception-translator-extend branch from 43563ef to e211b95 Compare June 23, 2023 08:59
@mipo256
Copy link
Contributor Author

mipo256 commented Jun 23, 2023

@mp911de Done)

@mp911de mp911de changed the title Make driver recognize Cluster request timeout Add exception translation for DriverTimeoutException Jul 3, 2023
@mp911de mp911de added this to the 4.2 M1 (2023.1.0) milestone Jul 3, 2023
mp911de pushed a commit that referenced this pull request Jul 3, 2023
@mp911de mp911de closed this in 7aa6507 Jul 3, 2023
mp911de added a commit that referenced this pull request Jul 3, 2023
Annotation serialVersionUID fields with Serial annotation.

See #1399
@mp911de
Copy link
Member

mp911de commented Jul 3, 2023

Thank you for your contribution. That's merged and polished now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants