Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

The TokenCount in the FieldType seems to be misspelled. #2024

Closed
oni7uka opened this issue Dec 13, 2021 · 2 comments · Fixed by #2026
Closed

The TokenCount in the FieldType seems to be misspelled. #2024

oni7uka opened this issue Dec 13, 2021 · 2 comments · Fixed by #2026
Assignees
@sothawo
Labels
type: bug A general bug
Milestone
4.4 M1 (2021.2.0)

Comments

@oni7uka
Copy link
Contributor

oni7uka commented Dec 13, 2021

Hi, guys
Datatype.TokenCount is mapped to tokencount, resulting in elasticsearch mapper_parsing_exception:

"type":"mapper_parsing_exception","reason":"no handler for type [tokencount] declared on field [length]"

The correct mapping should be token_count
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 13, 2021
@sothawo sothawo changed the title The TokenCount in the Datatype seems to be misspelled. The TokenCount in the FieldType seems to be misspelled. Dec 13, 2021
@sothawo sothawo added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 13, 2021
@sothawo
Copy link
Collaborator

sothawo commented Dec 13, 2021

Note: FieldType values are mapped by lowercasing their name. We should add the names explicitly to the enum to prevent such mistakes in the future.

@sothawo sothawo self-assigned this Dec 13, 2021
@sothawo sothawo mentioned this issue Dec 13, 2021
Merged
sothawo added a commit that referenced this issue Dec 13, 2021
@sothawo
Fix FieldType mapping.
f7a6a97 
Original PullRequest #2026
Closes #2024
@sothawo sothawo added this to the 4.4 M1 (2021.2.0) milestone Dec 13, 2021
sothawo added a commit that referenced this issue Dec 13, 2021
@sothawo
Fix FieldType mapping.
f3f9ca4 
Original PullRequest #2026
Closes #2024

(cherry picked from commit f7a6a97)
sothawo added a commit that referenced this issue Dec 14, 2021
@sothawo
Fix FieldType mapping.
1b59b31 
Original PullRequest #2026
Closes #2024

(cherry picked from commit f7a6a97)
(cherry picked from commit f3f9ca4)
@sothawo
Copy link
Collaborator

sothawo commented Dec 14, 2021

added in main and backported to 4.3.x and 4.2.x.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sothawo sothawo

Labels
type: bug A general bug
Projects
None yet
Milestone
4.4 M1 (2021.2.0)
Development

Successfully merging a pull request may close this issue.

Fix FieldType mapping sothawo/spring-data-elasticsearch
3 participants
@sothawo @oni7uka @spring-projects-issues