Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement support for reindex API [DATAES-955] #1529 #2070

Merged
merged 12 commits into from
Jan 26, 2022
Merged

Implement support for reindex API [DATAES-955] #1529 #2070

merged 12 commits into from
Jan 26, 2022

Conversation

oni7uka
Copy link
Contributor

@oni7uka oni7uka commented Jan 21, 2022

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our [issue tracker](https://github.
    com/spring-projects/spring-data-elasticsearch/issues)    . Add the issue number to the Closes #issue-number line below
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #1529

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 21, 2022
sothawo
sothawo requested changes Jan 23, 2022
View reviewed changes
Copy link
Collaborator

@sothawo sothawo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks for this good work.
Most of my comments are minor things; the biggest change request is to use our Query interface in the API instead fo the Elasticsearch QueryBuilder class.

src/main/java/org/springframework/data/elasticsearch/core/index/reindex/PostReindexRequest.java Outdated Show resolved Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/index/reindex/PostReindexRequest.java Outdated Show resolved Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/index/reindex/PostReindexRequest.java Outdated Show resolved Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/index/reindex/PostReindexRequest.java Outdated Show resolved Hide resolved
src/main/java/org/springframework/data/elasticsearch/core/index/reindex/PostReindexRequest.java Outdated Show resolved Hide resolved
src/main/java/org/springframework/data/elasticsearch/client/reactive/RequestCreator.java Show resolved Hide resolved
src/main/java/org/springframework/data/elasticsearch/client/reactive/RequestCreator.java Show resolved Hide resolved
src/test/java/org/springframework/data/elasticsearch/core/RequestFactoryTests.java Outdated Show resolved Hide resolved
...g/springframework/data/elasticsearch/core/ReactiveElasticsearchTemplateIntegrationTests.java Outdated Show resolved Hide resolved
src/test/java/org/springframework/data/elasticsearch/core/ElasticsearchTemplateTests.java Show resolved Hide resolved
oni7uka and others added 7 commits January 24, 2022 10:52
@oni7uka @sothawo
Update src/main/java/org/springframework/data/elasticsearch/core/Resp…
3744028 
…onseConverter.java


rename help method

Co-authored-by: Peter-Josef Meisch <pj.meisch@sothawo.com>
@oni7uka @sothawo
Update src/test/java/org/springframework/data/elasticsearch/core/Reac…
d3243fc 
…tiveElasticsearchTemplateIntegrationTests.java


independent of the client implementation

Co-authored-by: Peter-Josef Meisch <pj.meisch@sothawo.com>
@oni7uka
move to upper level package
7739550
@oni7uka
rename ReindexRequest and ReindexResponse
addf096
@oni7uka
fix source queries must be allowed for reindexing without a remote
e331855
@oni7uka
Merge branch 'main' of https://github.com/oni7uka/spring-data-elastic…
72a872f 
…search

# Conflicts:
#	src/main/java/org/springframework/data/elasticsearch/core/ResponseConverter.java
#	src/test/java/org/springframework/data/elasticsearch/core/ReactiveElasticsearchTemplateIntegrationTests.java
@oni7uka
Merge branch 'main' into main
8a0ca5c
@sothawo
Copy link
Collaborator

sothawo commented Jan 24, 2022

will have a look tomorrow or on thursday

@sothawo sothawo merged commit c5db583 into spring-projects:main Jan 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sothawo sothawo sothawo approved these changes

Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement support for reindex API [DATAES-955]
3 participants
@oni7uka @sothawo @spring-projects-issues