Skip to content

Add KeysetScrollIntegrationTests #3030

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add KeysetScrollIntegrationTests #3030

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jun 16, 2023

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 16, 2023
@quaff quaff mentioned this pull request Jun 16, 2023
Open
@mp911de
Copy link
Member

mp911de commented Jun 20, 2023

The test contains everything and nothing and is code without a clear focus. We have already some test cases for scrolling via specification, see RepositoryWithIdClassKeyTests. If we want to have additional test coverage then we should have a clearly defined feature or bug that we want to cover.

@mp911de mp911de closed this Jun 20, 2023
@mp911de mp911de added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @mp911de @spring-projects-issues