Skip to content

Add limit 0 behavior description #3999

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

raulmel1o
Copy link
Contributor

The number of items returned by the method Query limit(int limit) is equal to the value passed as a parameter. However, if the value is 0 the method returns all documents ignoring the "limit", this behavior may be misleading and I think it should be detailed in the documentation.

The number of items returned by the method `Query limit(int limit)` is equal to the value passed as a parameter. However, if the value is 0 the method returns all documents ignoring the "limit", this behavior may be misleading and I think it should be detailed in the documentation.
@pivotal-cla
Copy link

@raulmel1o Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@raulmel1o Thank you for signing the Contributor License Agreement!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 18, 2022
@christophstrobl christophstrobl self-assigned this Mar 28, 2022
@christophstrobl christophstrobl added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 28, 2022
christophstrobl added a commit that referenced this pull request May 10, 2022
Update Query javadoc.

Original Pull Request: #3999
christophstrobl pushed a commit that referenced this pull request May 10, 2022
This commit explains usage of Query.limit(int), which will be set to unlimited when set to zero or a negative value.

Closes: #3999
christophstrobl added a commit that referenced this pull request May 10, 2022
Update Query javadoc.

Original Pull Request: #3999
christophstrobl pushed a commit that referenced this pull request May 10, 2022
This commit explains usage of Query.limit(int), which will be set to unlimited when set to zero or a negative value.

Closes: #3999
christophstrobl added a commit that referenced this pull request May 10, 2022
Update Query javadoc.

Original Pull Request: #3999
@christophstrobl
Copy link
Member

@raulmel1o thanks for the contribution, merged and back ported.

@christophstrobl christophstrobl added this to the 3.3.5 (2021.1.5) milestone May 10, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants