Skip to content

Deprecate MongoCustomConversions.BigDecimalRepresentation.STRING #4957

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

therepanic
Copy link

@therepanic therepanic commented Apr 22, 2025

It is better to use BigInteger storage as Decimal128, so we should deprecate storage as strings.

Fix: #4920

Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 22, 2025
@mp911de mp911de changed the base branch from main to 5.0.x April 24, 2025 06:29
@mp911de mp911de changed the base branch from 5.0.x to main April 24, 2025 06:30
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 24, 2025
@mp911de mp911de added this to the 5.0 M3 (2025.1.0) milestone Apr 24, 2025
kssumin pushed a commit to kssumin/spring-data-mongodb that referenced this pull request May 2, 2025
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references.
When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax.

Closes spring-projects#4957

Signed-off-by: kssumin <205166@jnu.ac.kr>
kssumin pushed a commit to kssumin/spring-data-mongodb that referenced this pull request May 2, 2025
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references.
When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax.

Closes spring-projects#4957

Signed-off-by: kssumin <201566@jnu.ac.kr>
kssumin added a commit to kssumin/spring-data-mongodb that referenced this pull request May 2, 2025
This commit modifies the AddFieldsOperationBuilder to correctly treat String values as field references.
When a String value is passed, it is now interpreted as a reference to another field, following MongoDB's field reference syntax.

Closes spring-projects#4957

Signed-off-by: kssumin <201566@jnu.ac.kr>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate MongoCustomConversions.BigDecimalRepresentation.STRING
3 participants