Skip to content

RedisZSetCommands.ZAddArgs#isEmpty() negates empty flag #2588

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
duxugang opened this issue May 25, 2023 · 1 comment
Closed

RedisZSetCommands.ZAddArgs#isEmpty() negates empty flag #2588

duxugang opened this issue May 25, 2023 · 1 comment
Assignees
@mp911de
Labels
type: bug A general bug
Milestone
2.7.13 (2021.2.13)

Comments

@duxugang
Copy link

duxugang commented May 25, 2023 •
edited by mp911de
Loading

Class: RedisZSetCommands.ZAddArgs.
The judgment of flags is reversed

private final Set<Flag> flags;

public boolean isEmpty() {
			return !flags.isEmpty();
		}
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 25, 2023
@mp911de mp911de self-assigned this May 30, 2023
@mp911de mp911de added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 30, 2023
@mp911de mp911de changed the title RedisZSetCommands Inner class ZAddArgs have a small bug RedisZSetCommands.ZAddArgs#isEmpty() negates empty flag Jun 7, 2023
mp911de added a commit that referenced this issue Jun 7, 2023
@mp911de
Fix ZAddArgs.isEmpty.
f237016 
isEmpty now returns true if empty. Previously, the boolean returns were flipped.

Closes #2588
mp911de added a commit that referenced this issue Jun 7, 2023
@mp911de
Fix ZAddArgs.isEmpty.
bb57830 
isEmpty now returns true if empty. Previously, the boolean returns were flipped.

Closes #2588
mp911de added a commit that referenced this issue Jun 7, 2023
@mp911de
Fix ZAddArgs.isEmpty.
1ad01d4 
isEmpty now returns true if empty. Previously, the boolean returns were flipped.

Closes #2588
@mp911de mp911de added this to the 2.7.13 (2021.2.13) milestone Jun 7, 2023
@mp911de
Copy link
Member

mp911de commented Jun 7, 2023

Thanks for letting us know. That's fixed now.

@mp911de mp911de closed this as completed Jun 7, 2023
mp911de added a commit that referenced this issue Jun 8, 2023
@mp911de
Fix ZAddArgs.isEmpty.
e898159 
isEmpty now returns true if empty. Previously, the boolean returns were flipped.

Closes #2588
jxblum pushed a commit to jxblum/spring-data-redis that referenced this issue Jun 8, 2023
@mp911de @jxblum
Fix ZAddArgs.isEmpty.
a3cb205 
isEmpty now returns true if empty. Previously, the boolean returns were flipped.

Closes spring-projects#2588
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
2.7.13 (2021.2.13)
Development

No branches or pull requests
3 participants
@mp911de @spring-projects-issues @duxugang