Skip to content

Use SET command instead of SETEX #2897

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ehsanalemzadeh opened this issue Apr 21, 2024 · 2 comments
Closed

Use SET command instead of SETEX #2897

ehsanalemzadeh opened this issue Apr 21, 2024 · 2 comments
Assignees
@mp911de
Labels
type: enhancement A general enhancement
Milestone
3.4 RC1 (2024.1.0)

Comments

@ehsanalemzadeh
Copy link
Contributor

ehsanalemzadeh commented Apr 21, 2024 •
edited
Loading

In DefaultValueOperations, the set method with timeout argument calls the setEx command internally. However, SETEX command was deprecated in version 2.6.12 of Redis. According to Redis documentation, it is recommended to replace SETEX with SET using the EX argument. Redis documentation
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 21, 2024
@mp911de
Copy link
Member

mp911de commented Apr 23, 2024

Good catch. Do you want to submit a pull request?

@mp911de mp911de added status: ideal-for-contribution An issue that a contributor can help us with type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 23, 2024
@ehsanalemzadeh
Copy link
Contributor Author

Sure. I will do it soon.

ehsanalemzadeh added a commit to ehsanalemzadeh/spring-data-redis that referenced this issue Apr 24, 2024
@ehsanalemzadeh
Polishing.
e24b2a4 
Replace usage of deprecated commands setEx, pSetEx and setNX in DefaultValueOperations by set command with additional SetOption arguments

Closes #spring-projects#2897
@ehsanalemzadeh ehsanalemzadeh mentioned this issue Apr 24, 2024
Closed
@mp911de mp911de added this to the 3.4 RC1 (2024.1.0) milestone Oct 11, 2024
@mp911de mp911de removed the status: ideal-for-contribution An issue that a contributor can help us with label Oct 11, 2024
@mp911de mp911de self-assigned this Oct 11, 2024
mp911de added a commit that referenced this issue Oct 11, 2024
@mp911de
Polishing.
b1e07f5 
Replace subclass per command usage with lambdas.

See #2897
Original pull request: #2900
@mp911de mp911de linked a pull request Oct 11, 2024 that will close this issue
Use extended SET instead of deprecated setEx, pSetEx and setNX commands #2900
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4 RC1 (2024.1.0)
3 participants
@mp911de @spring-projects-issues @ehsanalemzadeh