Skip to content

Migrate to JSpecify annotations for nullability constraints #1980

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
mp911de opened this issue Jan 15, 2025 · 3 comments
Open

Migrate to JSpecify annotations for nullability constraints #1980

mp911de opened this issue Jan 15, 2025 · 3 comments
Labels
type: enhancement A general enhancement

Comments

@mp911de
Copy link
Member

mp911de commented Jan 15, 2025

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 15, 2025
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 15, 2025
@ivamly
Copy link

ivamly commented Jan 16, 2025

Hi, @mp911de!

Could I work on this issue or maybe a part of it? From what I understand, the task is about replacing @nullable and @nonnull annotations with JSpecify annotations, e.g., ensuring that the necessary imports are in place where they are currently used. Is there anything else I should know before I start working on this?

Thanks!

@mp911de
Copy link
Member Author

mp911de commented Jan 16, 2025

Hey @ivamly. There's quite a bit more attached to this task. JSpecify annotations relate to the type level while Spring's @Nullable is targeting parameters, fields, and methods. Also, we're looking to leverage @Contract and integrate with NullAway.

I highly suggest waiting until common infrastructure and dependency management in the build infrastructure is in place (see spring-projects/spring-data-commons#3170). If you give this topic another month or two, then you should have everything in place to start with the task on the module level.

@ivamly
Copy link

ivamly commented Jan 16, 2025

Thanks! I’ll wait for that.

mp911de added a commit that referenced this issue Feb 10, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Feb 11, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Feb 11, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Feb 21, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Mar 10, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Mar 11, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Mar 14, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Apr 10, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue Apr 25, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
schauder pushed a commit that referenced this issue May 12, 2025
Kotlin reacts to JSpecify with increased nullability requirements.

See #1980
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants