Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add sqlite support #1770

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add sqlite support #1770

wants to merge 2 commits into from

Conversation

rudolfschmidt
Copy link

I wanted to contribute with an SQL dialect for the project. I have tested it on my system and it works.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 14, 2024
This was referenced Apr 14, 2024
Open
Open
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 15, 2024
mp911de
mp911de requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@mp911de mp911de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion. It would make sense to include an additional dialect. Can you also include the JDBC driver changes necessary in pom.xml? We can look into test cases.

spring-data-r2dbc/src/main/java/org/springframework/data/r2dbc/dialect/DialectResolver.java Outdated Show resolved Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java Outdated Show resolved Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java Outdated Show resolved Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java Outdated Show resolved Hide resolved
...relational/src/main/java/org/springframework/data/relational/core/dialect/SQLiteDialect.java Outdated Show resolved Hide resolved
@mp911de mp911de changed the title add sqlite support Add sqlite support Apr 18, 2024
@mp911de
Copy link
Member

mp911de commented Apr 18, 2024

We discussed this effort as a team and concluded two things:

  1. Right now, we're the sole maintainers of each contributed dialect including chasing for bugfixes and dialect-specific enhancements.
  2. We would like to find a model that allows community-driven dialect contribution in a way that enables developers to test their features against our test specifications. For this to happen, we need to rework our tests first.

Once the second item is addressed we can look for a way to integrate the dialect.

For the time being, if you keep the code on your project, you can use the DialectResolver extension mechanism to configure the JdbcDialectProvider extension point via spring.factories.

@mp911de mp911de added the status: on-hold We cannot start working on this issue yet label Apr 18, 2024
@benjamin-dreux
Copy link

Any update on the subject ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mp911de mp911de mp911de requested changes

Assignees
No one assigned
Labels
status: on-hold We cannot start working on this issue yet type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rudolfschmidt @mp911de @benjamin-dreux @spring-projects-issues