JdbcCustomConversion does not reject non-Date related default converters anymore #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odrotbohm
changed the title
odrotbohm
changed the title
…ers. Previously, JdbcCustomConversion rejected any default converter that was not converting from and to java.util.Date. This probably stemmed from the fact that up until recently, Spring Data Commons' CustomConversions only registered date related default converters. As of spring-projects/spring-data-commons#2315 we also support jMolecules' Association and Identifier converters. We've relaxed the rejection to only explicitly reject all non Date/Time related converters if the conversion is from/to java.util.Date but allow everything else out of the box.
odrotbohm
force-pushed
the
feature/custom-conversions-fix
branch
from
87d6b52
to
5175c6a
Compare
schauder
pushed a commit
that referenced
this pull request
Mar 12, 2021
…ers. Previously, JdbcCustomConversion rejected any default converter that was not converting from and to java.util.Date. This probably stemmed from the fact that up until recently, Spring Data Commons' CustomConversions only registered date related default converters. As of spring-projects/spring-data-commons#2315 we also support jMolecules' Association and Identifier converters. We've relaxed the rejection to only explicitly reject all non Date/Time related converters if the conversion is from/to java.util.Date but allow everything else out of the box. Original pull request #937
|
Thanks, that's merged. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
JdbcCustomConversionrejected any default converter that was not converting from and tojava.util.Date. This probably stemmed from the fact that up until recently, Spring Data Commons'CustomConversionsonly registered date related default converters. As of spring-projects/spring-data-commons#2315 we also support jMolecules'AssociationandIdentifierconverters. We've relaxed the rejection to only explicitly reject all non Date/Time related converters if the conversion is from/tojava.util.Datebut allow everything else out of the box.