Skip to content

Commit

Permalink
Enforce Future/void return declaration for async methods
Browse files Browse the repository at this point in the history
Closes gh-27734
  • Loading branch information
jhoeller committed Dec 14, 2021
1 parent 37bebea commit 9a513cf
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2018 the original author or authors.
* Copyright 2002-2021 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -286,10 +286,14 @@ else if (ListenableFuture.class.isAssignableFrom(returnType)) {
else if (Future.class.isAssignableFrom(returnType)) {
return executor.submit(task);
}
else {
else if (void.class == returnType) {
executor.submit(task);
return null;
}
else {
throw new IllegalArgumentException(
"Invalid return type for async method (only Future and void supported): " + returnType);
}
}

/**
Expand Down

0 comments on commit 9a513cf

Please # to comment.