Skip to content

Improve Javadoc of ObjectProvider to clarify what is unique #34447

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Feb 19, 2025

No description provided.

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 19, 2025
@jhoeller jhoeller self-assigned this Mar 7, 2025
@jhoeller jhoeller added type: documentation A documentation task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Mar 7, 2025
@jhoeller jhoeller added this to the 6.2.4 milestone Mar 7, 2025
@jhoeller
Copy link
Contributor

jhoeller commented Mar 8, 2025

I put an explanation at the type-level javadoc instead since uniqueness primarily matters for {@link #getObject()} (or even direct injection point declarations without any ObjectProvider involved at all), with getIfUnique just being a special-purpose method that turns a non-unique case into a null return value. Also, I've worded it a bit differently. Thanks for the pull request, in any case!

@jhoeller jhoeller closed this in 4bd280b Mar 8, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: documentation A documentation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants