Support @Validated on method parameter

[hatotsumuri]

Hi.
I'm trying to add validation with GraphQL.

But "@validated" not working with "GraphQlController".
(I tried "GraphQlController × @Valid" and "RestController × @Validated" and they worked.)

Below is the source code.
If there are any missing settings, please kindly advise.

Thanks.

■Query

query ($accountCondition: AccountCondition)  {
	findAccountByCondition(accountCondition: $accountCondition) {
		accountId
		accountName
	}
}

■Query variables

{
	"accountCondition": {
		"accountName": "test"
	}
}

■schema.graphqls

input AccountCondition {
    accountId: Int
    accountName: String
}

type Account {
    accountId: ID!
    accountName: String
 }

type Query {
    findAccountByCondition(accountCondition: AccountCondition): [Account]
}

■AccountCondition

@Data
public class AccountCondition {
	@NotNull
	private Long accountId;
	private String accountName;
}

■GraphQLController × @validated → Validation not works.

import org.springframework.validation.annotation.Validated;
…
@Controller
@RequiredArgsConstructor
public class GraphQlController {
	private final AccountService accountService;

	@QueryMapping
	public List<Account> findAccountByCondition(
			@Argument @Validated AccountCondition accountCondition) {
		List<Account> accountList = accountService.findByCondition(
				accountCondition);
		return accountList;
	}
}

■GraphQLController × @Valid→ Validation works.

import javax.validation.Valid;
…
@Controller
@RequiredArgsConstructor
public class GraphQlController {
	private final AccountService accountService;

	@QueryMapping
	public List<Account> findAccountByCondition(
			@Argument @Valid AccountCondition accountCondition) {
		List<Account> accountList = accountService.findByCondition(
				accountCondition);
		return accountList;
	}
}

■RestController × @validated → Validation works.

import org.springframework.validation.annotation.Validated;
…
@Controller
@RequiredArgsConstructor
public class RestController {
	private final AccountService accountService;

	@PostMapping("/account/search")
	@ResponseBody
	public Result findAccountByCondition(
			@RequestBody @Validated AccountCondition accountCondition) {
		List<Account> accountList = accountService.findByCondition(
				accountCondition);
		return ResultUtil.newSuccess(accountList);
	}
}

[rstoyanchev]

We call standard bean validation to validate all the method parameters, and it does look like that requires @Valid.

Are you trying to specify validation groups? We do check for @Validated on the method, so you can specify groups that way still, but otherwise as it is currently you do need @Valid to trigger cascaded validation.

I think we could enhance our validation support to detect method parameters with @Validated but without @Valid and to apply validation on them, in addition to invoking standard bean validation for other method parameters.

[hatotsumuri]

Thank you for your advice.

Are you trying to specify validation groups?

Yes, I would like to use validation groups in graphGL.

We do check for @validated on the method, so you can specify groups that way still.

Thank you for the useful information.
I will try this implementation.

I think we could enhance our validation support to detect method parameters with @validated but without @Valid

It would be great if your can support this.

Thanks.