GH-3409: Improve exceptions during retry #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-projects#3409 - During error handling, records in retry are throwing `KafkaException` after seeking that causes the exception to get logged which maybe misleading. It seems to indicate that the error handling process itself thew the exception, while the exception was thrown in order to prevent accidental committing of a not-yet recovered record. Change this exception during seeks in retry while handling error from `KafkaException` to a new framework-only used exception - `RecordInRetryException` that simply logs the message at INFO level.
artembilan
requested changes
Aug 14, 2024
| @@ -2212,6 +2212,10 @@ private RuntimeException doInvokeBatchListener(final ConsumerRecords<K, V> recor | |||
| invokeBatchErrorHandler(records, recordList, e); | |||
| commitOffsetsIfNeededAfterHandlingError(records); | |||
| } | |||
| catch (RecordInRetryException rire) { | |||
| rire.selfLog(this.logger); | |||
There was a problem hiding this comment.
I wouldn't do this, but just this.logger.info("BLAH-BLAH", rire)
|
|
||
| void selfLog(LogAccessor logger) { | ||
| logger.info(this.message); | ||
| } |
There was a problem hiding this comment.
Just nit-pic: every member in the class must be surrounded with blank lines, even the last method of the last inner class.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3409
KafkaExceptionafter seeking that causes the exception to get logged which maybe misleading. It seems to indicate that the error handling process itself thew the exception, while the exception was thrown in order to prevent accidental committing of a not-yet recovered record. Change this exception during seeks in retry while handling error fromKafkaExceptionto a new framework-only used exception -RecordInRetryExceptionthat simply logs the message at INFO level.