refactor: simplify partitionSubset logic in ConcurrentMessageListenerContainer #3987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your Git client has to be configured for a proper author. Thank you |
bandalgomsu
force-pushed
the
refactor/partition-subset-cleanup
branch
3 times, most recently
from
2972fd6 to
dae5cee
Compare
|
I changed it accordingly ! I will continue to look for ways to simplify things too. Thanks for your comment :) |
|
Is there anything else I can do about this PR? @artembilan |
I don't thinks so. Sorry for inconvenience, and thank you for contribution! |
|
Thank you for your reply !! 🙂 |
bandalgomsu
force-pushed
the
refactor/partition-subset-cleanup
branch
from
dae5cee to
dcaed89
Compare
sobychacko
requested changes
Jul 3, 2025
Signed-off-by: Su Ko <rhtn1128@gmail.com>
bandalgomsu
force-pushed
the
refactor/partition-subset-cleanup
branch
from
02e3183 to
b39ca72
Compare
|
I've added |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the partitionSubset method to reduce nesting and improve readability while preserving original behavior.