Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OpenSamlAssertingPartyMetadataRepository should initialize OpenSAML #16042

Closed
jzheaux opened this issue Nov 6, 2024 · 4 comments · Fixed by #16055
Closed

OpenSamlAssertingPartyMetadataRepository should initialize OpenSAML #16042

jzheaux opened this issue Nov 6, 2024 · 4 comments · Fixed by #16055
Assignees
Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Nov 6, 2024

All OpenSamlXXX components should attempt to initialize OpenSAML.

For example, when OpenSaml5AssertingPartyMetadataRepository#withMetadataLocation is called, the method will fail if another component hasn't already initialized OpenSAML.

@jzheaux jzheaux added type: bug A general bug in: saml2 An issue in SAML2 modules labels Nov 6, 2024
@jzheaux jzheaux added this to the 6.4.0 milestone Nov 6, 2024
@ig-jinwoo
Copy link

Hi @jzheaux, Could I work on this issue?

@jzheaux
Copy link
Contributor Author

jzheaux commented Nov 8, 2024

Sure, @ig-jinwoo! It should involve adding the following:

static {
    OpenSamlInitializationService.initialize();
}

to both OpenSaml4 and OpenSaml5AssertingPartyMetadataRepository.

@jzheaux
Copy link
Contributor Author

jzheaux commented Nov 8, 2024

Also, note that this ticket is time-sensitive as it is targeting a release on November 18. If you get tied up and aren't able to put together a PR in the next few days, go ahead and let me know and I'll take care of things.

@ig-jinwoo
Copy link

Hi @jzheaux , thank you for providing additional details. I’ll aim to submit a PR as soon as possible, and if I cannot submit the PR by November 13, I’ll let you know.

ig-jinwoo pushed a commit to ig-jinwoo/spring-security that referenced this issue Nov 10, 2024
Closes spring-projectsgh-16042

This commit adds a static initializer block to both OpenSaml4AssertingPartyMetadataRepository
and OpenSaml5AssertingPartyMetadataRepository. This ensures OpenSAML is initialized upon class
loading, preventing failures when methods like withMetadataLocation are invoked without prior
initialization.
ig-jinwoo pushed a commit to ig-jinwoo/spring-security that referenced this issue Nov 10, 2024
Closes spring-projectsgh-16042

This commit adds a static initializer block to both OpenSaml4AssertingPartyMetadataRepository
and OpenSaml5AssertingPartyMetadataRepository. This ensures OpenSAML is initialized upon class
loading, preventing failures when methods like withMetadataLocation are invoked without prior
initialization.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants