-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Improve error messaging when use-authorization-manager and access-decision-manager-ref conflict #16193
Comments
Good idea, @Spikhalskiy. I think the message could be improved to suggest a remediation:
Are you able to submit a PR that imrpoves the message? |
access-decision-manager-ref
" message
@jzheaux I definitely can adjust it this way. But I am concerned that this makes the message too focused on XML-based configuration, specifically "your |
My apologies, I overlooked your existing PR. I'll add any additional comments over there. Closing in favor of #16194 |
- aligned the grammar - formatted using gradlew format - updated copyright year Issue spring-projectsgh-16193
- aligned the grammar - formatted using gradlew format - updated copyright year Issue gh-16193
Current Behavior
The user has a project with Spring Security utilizing Access Decision Manager classes.
They have the following in their security.xml:
The project is based on Spring 5.x and they migrate to Spring 6.x.
The user would get an error
without having any
AuthorizationManager
beans configured.This error message is confusing because it makes the user look for AuthorizationManager usages in the project.
Expected Behavior
If the error message pointed the user at the right attribute, it would save investigation time for users who perform the migration. It already gives a specific attribute name for
access-decision-manager-ref
. It should also give a reference touse-authorization-manager
and highlight that it's true by default.Context
The solution if the user doesn't want to migrate onto the new
AuthorizationManager
yet is to specifyThe text was updated successfully, but these errors were encountered: