Skip to content

Add RestClient implementations #15337

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Conversation

sjohnr
Copy link
Contributor

@sjohnr sjohnr commented Jul 1, 2024

To Do:

  • Add unit tests
  • Add integration tests
  • Add reference documentation

This PR adds implementations of OAuth2AccessTokenResponseClient that use RestClient as the underlying HTTP client. These implementations offer behavior and configuration similar to the WebClient-based implementations, which provides consistency for issues such as gh-11298 and gh-14811. See theme issue gh-15299 for more context.

Closes gh-15298

@sjohnr sjohnr added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jul 1, 2024
@sjohnr sjohnr self-assigned this Jul 1, 2024
@sjohnr sjohnr added this to the 6.4.0-M1 milestone Jul 1, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 6.4.0-M1, 6.4.0-M2 Jul 15, 2024
@sjohnr sjohnr modified the milestones: 6.4.0-M2, 6.4.0-M3 Aug 19, 2024
@marcusdacoregio marcusdacoregio modified the milestones: 6.4.0-M3, 6.4.0-M4 Aug 22, 2024
@sjohnr sjohnr marked this pull request as ready for review September 10, 2024 19:01
@sjohnr
Copy link
Contributor Author

sjohnr commented Sep 10, 2024

Closed via 2cead9b

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding RestClient implementations of OAuth2AccessTokenResponseClient
2 participants