Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve documentation about CredentialsContainer #15554

Merged

Conversation

Chu3laMan
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 11, 2024
@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Aug 14, 2024

Hi @Chu3laMan, thanks for the PR! Would you mind clarifying why you replaced the javadoc: macro? We are moving to use this macro now and it should be used.

@marcusdacoregio marcusdacoregio self-assigned this Aug 14, 2024
@marcusdacoregio marcusdacoregio added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 14, 2024
@Chu3laMan
Copy link
Contributor Author

Chu3laMan commented Aug 17, 2024

Hi @Chu3laMan, thanks for the PR? Would you mind clarifying why you replaced the javadoc: macro? We are moving to use this macro now and it should be used.

Hi @marcusdacoregio thank you for your remark, I already fix it ... could you check por favor?

@marcusdacoregio marcusdacoregio removed their assignment Sep 17, 2024
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Chu3laMan. I have added a few comments inline below.

@sjohnr sjohnr self-assigned this Oct 24, 2024
@sjohnr sjohnr added the status: waiting-for-feedback We need additional information before we can continue label Nov 4, 2024
@sjohnr sjohnr force-pushed the feature/15398-credentialsContainer branch from 75d52de to 909dcc6 Compare November 13, 2024 20:48
sjohnr added a commit to Chu3laMan/spring-security that referenced this pull request Nov 13, 2024
@sjohnr sjohnr force-pushed the feature/15398-credentialsContainer branch from 909dcc6 to 81808c5 Compare November 13, 2024 20:56
@sjohnr sjohnr merged commit f115984 into spring-projects:main Nov 13, 2024
6 checks passed
@sjohnr sjohnr removed the status: waiting-for-feedback We need additional information before we can continue label Nov 13, 2024
@sjohnr sjohnr added this to the 6.4.0 milestone Nov 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants