Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix error when Bearer token is requested with empty string #15940

Closed
wants to merge 2 commits into from
Closed

Fix error when Bearer token is requested with empty string #15940

wants to merge 2 commits into from

Conversation

jacknie84
Copy link
Contributor

Issue gh-15885

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 18, 2024
sjohnr
sjohnr requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jacknie84, thanks for the PR! Please see comment below. Also there are failures on the build. Let me know if you need any assistance with the build output.

...org/springframework/security/oauth2/server/resource/web/DefaultBearerTokenResolverTests.java Show resolved Hide resolved
@jacknie84
Copy link
Contributor Author

Hi @sjohnr. Thank you for your review.
I've made all the changes you asked for.
and I updated the test code because it was failing due to recent code changes.
Please review it once again.

@jzheaux jzheaux assigned jzheaux and sjohnr and unassigned jzheaux Oct 23, 2024
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 23, 2024
@sjohnr sjohnr added the type: bug A general bug label Oct 24, 2024
@sjohnr sjohnr added this to the 6.4.x milestone Oct 24, 2024
@sjohnr
Copy link
Member

sjohnr commented Oct 29, 2024

@jacknie84 the PR Build failed due to code formatting issues related to imports. Let me know if you need any assistance.

@jacknie84
Copy link
Contributor Author

@sjohnr Sorry~
The results of the ':spring-security-oauth2-resource-server:checkstyleTest' task were checked and action was taken.
Thank you.

sjohnr added a commit that referenced this pull request Nov 4, 2024
@sjohnr
Polish gh-15940
86f3cd6 
Closes gh-15885
@sjohnr
Copy link
Member

sjohnr commented Nov 4, 2024 •
edited
Loading

Thanks @jacknie84! This has been merged into 6.2.x as 4c6fef8 along with polish commit 86f3cd6.

@sjohnr sjohnr closed this Nov 4, 2024
@sjohnr sjohnr modified the milestones: 6.4.x, 6.2.8 Nov 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjohnr sjohnr sjohnr approved these changes

Assignees

@sjohnr sjohnr

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
Spring Security Team
Status: Done
Milestone
6.2.8
Development

Successfully merging this pull request may close these issues.
4 participants
@jacknie84 @sjohnr @jzheaux @spring-projects-issues