Skip to content

Add Support ServerFormPostRedirectStrategy #16551

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 19, 2025
Merged

Add Support ServerFormPostRedirectStrategy #16551

merged 3 commits into from
Feb 19, 2025

Conversation

franticticktick
Copy link
Contributor

Closes gh-16542

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 7, 2025
@franticticktick
Copy link
Contributor Author

@sjohnr thanks for trusting me with this ticket. I opened a separate issue #16556 and linked a second commit to it. Could you review this PR please?

@sjohnr sjohnr self-assigned this Feb 14, 2025
@sjohnr sjohnr added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 14, 2025
sjohnr
sjohnr suggested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @franticticktick, this looks great so far! I added one minor comment for now, and then I will review this more thoroughly before merging and can make any other minor adjustments if I find anything.

@sjohnr sjohnr enabled auto-merge (rebase) February 19, 2025 19:37
@sjohnr
Copy link
Contributor

sjohnr commented Feb 19, 2025 •
edited
Loading

Thanks @franticticktick! I have made some minor adjustments in a polish commit to align the two implementations visually, consistent final usage (I don't have a preference, but just so the usage is internally consistent in the class), added DataBufferUtils.release() on error, and renamed the class. This will merge when checks pass. Note that I force-pushed the branch.

@sjohnr sjohnr added this to the 6.5.0-M3 milestone Feb 19, 2025
@sjohnr sjohnr merged commit 7fc5d50 into spring-projects:main Feb 19, 2025
5 of 6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sjohnr sjohnr sjohnr approved these changes

Assignees

@sjohnr sjohnr

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-M3
Development

Successfully merging this pull request may close these issues.

Support POST method for ServerRedirectStrategy
3 participants
@franticticktick @sjohnr @spring-projects-issues