Skip to content

Refactored Http403ForbiddenEntryPoint to use HttpStatus.FORBIDDEN.value #16616

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Refactored Http403ForbiddenEntryPoint to use HttpStatus.FORBIDDEN.value #16616

merged 1 commit into from
Mar 7, 2025

Conversation

yelm-212
Copy link
Contributor

Fixes #16615

  • Replaced hardcoded 403 in Http403ForbiddenEntryPoint with HttpStatus.FORBIDDEN.value()
  • Ensures consistency with BasicAuthenticationEntryPoint and DelegatingAuthenticationEntryPoint
  • No breaking changes, maintains existing behavior

@yelm-212 yelm-212 marked this pull request as ready for review February 18, 2025 04:32
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 18, 2025
@jzheaux jzheaux mentioned this pull request Feb 24, 2025
Closed
@jzheaux jzheaux self-assigned this Feb 24, 2025
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 24, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Feb 24, 2025

Hi, @yelm-212, thanks for your contribution!

Will you please sign your commit?

Also, will you edit your commit message to include the issue number on its own line like this:

Closes gh-16615

Lastly, would you please update the copyright year in Http403ForbiddenEntryPoint?

@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label Feb 24, 2025
@yelm-212 yelm-212 force-pushed the fix-http-status-consistency branch 2 times, most recently from 51d4eac to 5a5ad51 Compare February 25, 2025 06:16
@yelm-212
Copy link
Contributor Author

I've made the requested updates. Let me know if there's anything else I should adjust. Thanks!

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 25, 2025
@yelm-212 @jzheaux
Update Http403ForbiddenEntryPoint to Use HttpStatus
0e321aa 
Closes spring-projectsgh-16615

Signed-off-by: yelm-212 <21yrshin@naver.com>
@jzheaux jzheaux force-pushed the fix-http-status-consistency branch from 5a5ad51 to 0e321aa Compare February 27, 2025 22:27
@jzheaux jzheaux removed the status: feedback-provided Feedback has been provided label Feb 27, 2025
@jzheaux jzheaux added this to the 6.5.0-M3 milestone Feb 27, 2025
@jzheaux jzheaux merged commit cfefcca into spring-projects:main Mar 7, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Mar 7, 2025

Thanks so much for this PR, @yelm-212! This is now merged into main.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-M3
Development

Successfully merging this pull request may close these issues.

Replace Hardcoded 403 in Http403ForbiddenEntryPoint with HttpStatus.FORBIDDEN.value()
3 participants
@yelm-212 @jzheaux @spring-projects-issues