Sorting in AuthorizationAdvisorProxyFactory should be thread-safe #16834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks, @ngocnhan-tran1996 for the PR! I've left some feedback inline.
...java/org/springframework/security/authorization/method/AuthorizationAdvisorProxyFactory.java
Show resolved
Hide resolved
...t/java/org/springframework/security/authorization/AuthorizationAdvisorProxyFactoryTests.java
Outdated
Show resolved
Hide resolved
jzheaux
added
in: core
|
Additionally, will you please rebase this on |
ngocnhan-tran1996
force-pushed
the
gh-16819
branch
from
bc75585 to
0d7762d
Compare
ngocnhan-tran1996
changed the title
SmartInitializingSingleton for preventing ConcurrentModificationException
In order to make so that authorization advisors are sorted only one time and also as part of the configuration lifecycle, AuthorizationAdvisorProxyFactory now implements SmartInitializingBean. Closes spring-projectsgh-16819 Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
This commit ensures that the default advisors and added advisors are sorted in the event that this component is not being published as a Spring bean. Issue spring-projectsgh-16819
jzheaux
changed the title
SmartInitializingSingleton for preventing ConcurrentModificationException
|
Thanks for the quick turnaround on this PR, @ngocnhan-tran1996! I added a polish commit to take care of scenarios where |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16819