Fix DPoP jkt claim to be JWK SHA-256 thumbprint #17080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Just used the nimbus JOSE library to do it, because it already has a compliant implementation. Signed-off-by: David Kowis <david@kow.is>
The other method remains for the `ath` claims Signed-off-by: David Kowis <david@kow.is>
jgrandja
changed the title
jgrandja
added
type: bug
jgrandja
added
the
in: oauth2
jgrandja
pushed a commit
that referenced
this pull request
May 13, 2025
Just used the nimbus JOSE library to do it, because it already has a compliant implementation. Closes gh-17080 Signed-off-by: David Kowis <david@kow.is>
|
@dkowis Thank you for catching this! This is now merged along with a minor polish commit. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the proper implementation for a JWK Thumbprint. Spring Security was doing a Certificate Thumbprint, which is correct for
athclaims to verify the certificate used in the JWK, but it's not correct for a DPoP verificationjktclaim.Resolves #17079