Reuse StringRedisSerializer instance #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
Thanks for the suggestion @quaff. Since this is a sample configuration, I don't see the need for this change if it doesn't cause any problems. |
eleftherias
added
status: waiting-for-feedback
vpavic
suggested changes
Aug 19, 2022
There was a problem hiding this comment.
I'd merge this. There's no need to instantiate additional serializer instances when Spring Data Redis offers RedisSerializer#string exactly to avoid that.
Note @quaff that there are more occurrence of this in RedisHttpSessionConfiguration and RedisWebSessionConfiguration.
spring-projects-issues
added
status: feedback-provided
marcusdacoregio
added
type: enhancement
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.