Skip to content

adjust and enhance NotRegisteredBeansReconciler #1530

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
martinlippert opened this issue Mar 28, 2025 · 1 comment
Closed

adjust and enhance NotRegisteredBeansReconciler #1530

martinlippert opened this issue Mar 28, 2025 · 1 comment
Assignees
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols theme: validation type: enhancement

Comments

@martinlippert
Copy link
Member

We need to improve the NotRegisteredBeansReconciler to take advantage of the newly introduced logic to re-run reconcilers with a completely build index and to re-trigger validations across files, when necessary.

For the NotRegisteredBeansReconciler, this means:

  • require complete index handling
  • re-validate if bean method is added or removed (for the concrete type of the class under validation)
  • re-validate if the factories file changes (adds or removes references to the class under validation)

For the reference:

3d1ccd7 introduced the feature for reconcilers to re-run with a fully build index, so that they can rely on index elements to be around for the validation checks.

ca4fc3c adds this logic to the reconcilers and indexing logic that takes care of feign client and feign config declarations.

@martinlippert martinlippert self-assigned this Mar 28, 2025
@martinlippert martinlippert added theme: spring index & symbols for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: validation and removed status: waiting-for-triage labels Mar 28, 2025
@martinlippert martinlippert added this to the 4.30.0.RELEASE milestone Mar 28, 2025
martinlippert added a commit that referenced this issue Mar 28, 2025
…cated test cases as a start for further testing
martinlippert added a commit that referenced this issue Mar 31, 2025
martinlippert added a commit that referenced this issue Mar 31, 2025
@martinlippert
Copy link
Member Author

The piece about reacting to changes of *.factories files is extracted to #1531

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
for: eclipse something that is specific for Eclipse for: vscode something that is specific for VSCode theme: spring index & symbols theme: validation type: enhancement
Projects
None yet
Development

No branches or pull requests

1 participant