Skip to content

Concourse extension doesn't know about tag_file for docker-image resource #197

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
marco-m opened this issue Feb 5, 2019 · 5 comments
Closed
Milestone

Comments

@marco-m
Copy link

marco-m commented Feb 5, 2019

Hello,

consider the following pipeline:

resources:

- name: banana-img.git
  type: docker-image
  source:
    repository: repo/banana-scratch-build

- name: repo.git
  type: git
  source:
    uri: https://example.com/repo.git

jobs:

- name: work-img
  plan:

  - get: repo.git
  - put: banana-img.git
    params:
      build: repo.git/img
      tag_prefix: hello
      tag_file: repo.git/img/tag_file

the extension says:

Unknown property 'tag_file' for type 'DockerImagePutParams'

tag

@kdvolder
Copy link
Member

kdvolder commented Feb 5, 2019

For easy reference: https://github.com/concourse/docker-image-resource

At first glance, it looks like there's multiple changes around use of tags. E.g. the 'tag' property is now deprecated. Should make a pass through the above linked doc, compare to our schema and make list of all the changes and sync us up again.

@spring-projects-issues
Copy link

spring-projects-issues commented Feb 5, 2019

(comment in Pivotal Tracker added by Kris De Volder:)

New in PutParams:

  • labels
  • labels_file
  • tag -> became deprecated
  • tag_file

@kdvolder
Copy link
Member

kdvolder commented Feb 6, 2019

Delivered, so you can try this out from snapshot .vsix file in vscode if you want. Download here: http://dist.springsource.com/snapshot/STS4/nightly-distributions.html

@kdvolder kdvolder closed this as completed Feb 6, 2019
@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Martin Lippert:)

The things that are mentioned here seem to work, but I am having trouble getting content-assist to show up the right proposals. Will file a bug report about that, since it looks like a more general issue with content-assist and not related to this specific resource type.

@marco-m
Copy link
Author

marco-m commented Feb 6, 2019

@kdvolder again, thanks a lot! Tested the nightly and it works fine!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants