add ES2015 variables #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Looks great. Should we also specify strict mode? I don't know what the Shunter convention is, but it's generally recommended elsewhere. |
|
👍 |
|
Something I'm doing now, which might be worth adding here if you agree, is using There's some good background here: https://ada.is/blog/2015/07/13/immutable/ |
Standard practice is to just use regular camelCase. If you go with the const as default approach then you can assume that everything is immutable and you don’t need a naming convention (not that a naming convention would necessarily be a good idea anyway, unless you have some way to enforce it. They're too easy for people to ignore/forget/be-unaware-of, and then you have the potential for confusion)
|
Thanks @rowanmanning - better now? |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.