Verify jwt without key id field #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi there, I sent in a signed CLA Oct 6, 2021. But let me know if you need a new one for whatever reason. |
|
I signed a new one, just in case it makes things easier. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows JWT-formatted VCs and VPs to be verified even when they don't have a "kid" field specified.
See #478 for context.
I've been using this code in a forked version of ssi crate in my codebase for some time now, based on an earlier version of ssi crate. I'm not able to run the cargo tests for ssi-vc crate (see #521), but the vc-test-suite tests do pass.
Is there a full battery of tests that I can run, and if so, how?