Skip to content

Fix signed foreign keys #38

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachee54
Copy link

PR Description

Migration command fails due to malformed foreign keys.
It appears that the foreign keys were recently defined as unsigned, while the referenced primary keys are signed by default.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #38 (37fb06d) into master (ac3da02) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage     83.49%   83.49%           
  Complexity      865      865           
=========================================
  Files            56       56           
  Lines          3218     3218           
=========================================
  Hits           2687     2687           
  Misses          531      531           

@zachee54
Copy link
Author

May it depend on the database engine ?

@dereuromark
Copy link
Contributor

Most likely on the strictness (version) of the DB, yeah

@zachee54
Copy link
Author

zachee54 commented Oct 2, 2023

In this case, may it be convenient not to specify any 'signed' clause in order to rely on DB default ?

@dereuromark
Copy link
Contributor

With Cake5 actually this works: dereuromark@8ae0683
This is probably due to phinx 0.15 and the defaults on signed and primary keys etc.

Maybe this would also be useful then already within Cake4?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants