remove upgrade and user data collection code #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❤️ Thanks for supporting this fork the way you do !!!! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the creation of this fork, PySimpleGUI included code that would collect user system data and send it to an 'upgrade server' as well as perform upgrades by receiving responses from the upgrade server and downloading files from GitHub dynamically. This functionality was not only insecure but, in my personal estimations, violated the privacy of PySimpleGUI users.
This functionality was already effectively disabled prior to the first PyPI release of
FreeSimpleGUI(the addresses to the remote servers, presumably controlled by the author(s) of PySimpleGUI were removed from the source code, so attempted data collections/upgrades would simply fail) -- this change is just a cleanup effort and completely removes this now-dead/ineffective code.To be certain and for the avoidance of any doubt: the maintainers of
FreeSimpleGUI(me) have never used theFreeSimpleGUIsoftware to collect data of its users without consent (or otherwise) and it will never do so. We firmly believe in your rights to privacy and promise to continue working to respect that privacy.