Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Always detect missing deploy and revert scripts #850

Closed
wants to merge 1 commit into from
Closed

Conversation

theory
Copy link
Collaborator

@theory theory commented Jan 1, 2025

Add checks for the existence of deploy and revert scripts before executing them (or logging them). Requires the presence of various test files in order for t/engine.t to work, as it previously created new changes willy-nilly without needing or caring about deploy and revert scripts. Hence all the new files in t/sql.

Add checks for the existence of deploy and revert scripts before
executing them (or logging them). Requires the presence of various test
files in order for `t/engine.t` to work, as it previously created new
changes willy-nilly without needing or caring about deploy and revert
scripts. Hence all the new files in `t/sql`.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12565124292

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12563451016: 0.0%
Covered Lines: 4535
Relevant Lines: 4535

💛 - Coveralls

@autarch autarch changed the title Always detect missing deploy and revert scsripts Always detect missing deploy and revert scripts Jan 2, 2025
@theory theory closed this Jan 3, 2025
@theory theory deleted the issue-828 branch January 3, 2025 16:22
@theory
Copy link
Collaborator Author

theory commented Jan 4, 2025

Merged in 7388a13.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants