Fix incorrect generate model names for "metadata" suffix #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qanghaa
force-pushed
the
fix/incorrect_generate_model_names
branch
2 times, most recently
from
853d233 to
89c110b
Compare
kyleconroy
reviewed
Sep 3, 2024
Comment on lines
7
to
9
| type Bonuse struct { | ||
| ID string | ||
| } |
There was a problem hiding this comment.
This appears to still be wrong here?
There was a problem hiding this comment.
Ah sorry, I just deleted this one from PR 👍
qanghaa
changed the title
kyleconroy
force-pushed
the
fix/incorrect_generate_model_names
branch
from
4072241 to
17fea60
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Table "bonuses" and "product_metadata" incorrectly generates model name. #3552