Prevent retention of cached object reference across async boundary #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che access (sqlpage#193)" This reverts commit b8c6ab8.
lorefnon
force-pushed
the
ref-async-boundary-retention-fix
branch
from
6f66707 to
d84002e
Compare
lovasoa
requested changes
Jan 21, 2024
| @@ -96,21 +96,25 @@ impl<T: AsyncFromStrWithState> FileCache<T> { | |||
| } | |||
|
|
|||
| pub async fn get(&self, app_state: &AppState, path: &PathBuf) -> anyhow::Result<Arc<T>> { | |||
| log::trace!("Attempting to get from cache {:?}", path); | |||
| if let Some(cached) = self.cache.read().await.get(path) { | |||
| if let Some(cached) = self.cache.get(path) { | |||
There was a problem hiding this comment.
I think we just need to clone the result of self.cache.get before if..let here.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context